linux-kernel - Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702260741040.12485@woody.linux-foundation.org>
Date:	Mon, 26 Feb 2007 07:51:19 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jiri Slaby <jirislaby@...il.com>
cc:	Uwe Bugla <uwe.bugla@....de>, akpm@...ux-foundation.org,
	bunk@...sta.de, linux-kernel@...r.kernel.org,
	Stephane Eranian <eranian@....hp.com>, Andi Kleen <ak@...e.de>
Subject: Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot
 be mounted without hanging up the whole system

On Mon, 26 Feb 2007, Jiri Slaby wrote:
> 
> Ok, this commit is the culprit:
> Commit: 2ff2d3d74705d34ab71b21f54634fcf50d57bdd5
> Author: Stephane Eranian <eranian@....hp.com> Tue, 13 Feb 2007 13:26:22 +0100
> 
>     [PATCH] i386: add idle notifier

Interesting. It doesn't touch floppy at all, but it *does* seem to play 
around with irq state. 

In particular, the floppy uses IRQF_DISABLED (which means that it doesn't 
want interrupts enabled when in the irq handler), and I get the feeling 
that the poll_idle() stuff made that not work.

That said, the only thing that *really* seems to change (as far as a 
floopy driver could notice) is the added "exit_idle()" in the do_IRQ() 
sequence, and I'm not seeing that one enabling interrupts. 

But the idle sequence definitely does (ie now we disable/enable interrupts 
in cpu_idle(). I'm not seeing why that should matter, though.

Stephane, any ideas?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/