linux-kernel - Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702260906540.12485@woody.linux-foundation.org>
Date:	Mon, 26 Feb 2007 09:10:22 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Benjamin LaHaise <bcrl@...ck.org>
cc:	Jiri Slaby <jirislaby@...il.com>, Uwe Bugla <uwe.bugla@....de>,
	akpm@...ux-foundation.org, bunk@...sta.de,
	linux-kernel@...r.kernel.org,
	Stephane Eranian <eranian@....hp.com>, Andi Kleen <ak@...e.de>
Subject: Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot
 be mounted without hanging up the whole system

On Mon, 26 Feb 2007, Benjamin LaHaise wrote:
> 
> Side note: this patch adds several function calls (4), several additional 
> L1 cache touches and a generally inefficient code path to *every single 
> interrupt that exits from the idle poll*, not to mention the extra (useless, 
> as it doesn't get used on 99.9% of deployed systems) function call and cache 
> touches to every single interrupt.

It is in fact possible that the floppy failure might just be from some 
timing-dependent thing, and the slowdown itself is the problem.

Although I do find that a bit unlikely, since machines these days are 
about a million times faster than they used to be, so even if it's 
unnecessarily slow, it shouldn't be noticeable for a floppy drive.

>  Keep in mind that systems acting as routers will often be sitting in 
> the idle loop when processing interrupts.  At the very least this 
> overhead (which is noticable on profiles) should be configurable.  I 
> don't think that my 586 class embedded routers really need this crap to 
> be going into the kernel.

I'm inclined to agree. Considering that the patch is known to cause 
problems, and that it's apparently broken on x86 *anyway* (the 
idle_notifier_register function isn't even exported), and considering that 
it's clearly bad for interrupt performance and could have been done a lot 
better, I would suggest just ripping it all out.

And I think we should do the same for x86-64 too..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/