linux-kernel - [PATCH 2.6.21-rc1] sparc64: fix CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702261854.l1QIs8D9013016@alkaid.it.uu.se>
Date:	Mon, 26 Feb 2007 19:54:08 +0100 (MET)
From:	Mikael Pettersson <mikpe@...uu.se>
To:	davem@...emloft.net
Cc:	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org
Subject: [PATCH 2.6.21-rc1] sparc64: fix CONFIG_PCI_MSI=n compile failure

2.6.21-rc1 fails to build on sparc64 when CONFIG_PCI_MSI=n:

  gcc -Wp,-MD,arch/sparc64/kernel/.irq.o.d  -nostdinc -isystem /home/mikpe/pkgs/linux-sparc64/gcc-4.1.2/lib/gcc/sparc64-unknown-linux-gnu/4.1.2/include -D__KERNEL__ -Iinclude  -include include/linux/autoconf.h -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Os -m64 -pipe -mno-fpu -mcpu=ultrasparc -mcmodel=medlow -ffixed-g4 -ffixed-g5 -fcall-used-g7 -Wno-sign-compare -Wa,--undeclared-regs -fomit-frame-pointer  -fno-stack-protector -Wdeclaration-after-statement -Wno-pointer-sign -Werror   -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(irq)"  -D"KBUILD_MODNAME=KBUILD_STR(irq)" -c -o arch/sparc64/kernel/irq.o arch/sparc64/kernel/irq.c
cc1: warnings being treated as errors
arch/sparc64/kernel/irq.c:113: warning: 'virt_irq_free' defined but not used
make[1]: *** [arch/sparc64/kernel/irq.o] Error 1
make: *** [arch/sparc64/kernel] Error 2

Most other MSI stuff in irq.c is #ifdef CONFIG_PCI_MSI.
So do the same for virt_irq_free() to fix this problem.

Signed-off-by: Mikael Pettersson <mikpe@...uu.se>

--- linux-2.6.21-rc1/arch/sparc64/kernel/irq.c.~1~	2007-02-26 17:47:54.000000000 +0100
+++ linux-2.6.21-rc1/arch/sparc64/kernel/irq.c	2007-02-26 18:01:55.000000000 +0100
@@ -109,6 +109,7 @@ static unsigned char virt_irq_alloc(unsi
 	return ent;
 }
 
+#ifdef CONFIG_PCI_MSI
 static void virt_irq_free(unsigned int virt_irq)
 {
 	unsigned int real_irq;
@@ -121,6 +122,7 @@ static void virt_irq_free(unsigned int v
 
 	__bucket(real_irq)->virt_irq = 0;
 }
+#endif
 
 static unsigned int virt_to_real_irq(unsigned char virt_irq)
 {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/