linux-kernel - Re: [PATCH] Remove redundant #ifdef __KERNEL_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702261615030.26687@CPE00045a9c397f-CM001225dbafb6>
Date:	Mon, 26 Feb 2007 16:16:08 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	"H. Peter Anvin" <hpa@...or.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	trivial@...nel.org
Subject: Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

On Mon, 26 Feb 2007, H. Peter Anvin wrote:

> Robert P. J. Day wrote:
> > On Sun, 25 Feb 2007, H. Peter Anvin wrote:
> >
> > > Robert P. J. Day wrote:
> > > >   Remove the redundant intermediate checks for __KERNEL__ since, as
> > > > soon as one ends, the next one starts.
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> > > >
> > > However, what's much worse is that this already has put series of
> > > constants which are part of the ABI under __KERNEL__.  This is a
> > > very bad thing.
> >
> > i'm sure i'm just being dense but i have no clue what you're
> > referring to.  AFAICT, that patch simply removed some redundant
> > preprocessor directives.  am i missing something?

> I'm referring to the the patch that caused the redundant ifdefs,
> which was a recent change which among other things broke klibc.

ah, i didn't realize that the redundant ifdef's themselves were a
symptom of another problem.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/