| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Feb 2007 22:25:55 +0100 (CET)
From: Jiri Kosina <jikos@...os.cz>
To: Henrique de Moraes Holschuh <hmh@....eng.br>
cc: Richard Purdie <rpurdie@...ys.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: ibm-acpi: improve backlight power handling (v2)
On Mon, 26 Feb 2007, Henrique de Moraes Holschuh wrote:
> static int brightness_update_status(struct backlight_device *bd)
> {
> - return brightness_set(bd->props.brightness);
> + return brightness_set(
> + (bd->props.fb_blank == FB_BLANK_UNBLANK &&
> + bd->props.power == FB_BLANK_UNBLANK) ?
> + bd->props.brightness : 0);
> }
Are you sure about the '&&'? The original patch I submitted to you earlier
today was checking for (bd->props.fb_blank == FB_BLANK_UNBLANK ||
bd->props.power == FB_BLANK_UNBLANK), and I tested it (to some extent) and
it worked well - no sudden unblanking without reason, no blinking, etc.
I also think that common sense implies that the condition should be
logical or - backlight layer could request blanking without requesting
powering the device off, right? We want to handle unblanking from such
situation properly, which doesn't necessairly mean we will get
bd->props.power == FB_BLANK_UNBLANK, right?
--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists