linux-kernel - Re: [PATCH] libata: handle ata_pci_device_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 Feb 2007 22:01:14 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Dmitriy Monakhov <dmonakhov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH] libata: handle ata_pci_device_do_resume() failure while
 resuming

On Sat, 24 Feb 2007 00:43:18 +0300 Dmitriy Monakhov wrote:

> Since commit:553c4aa630af7bc885e056d0436e4eb7f238579b
> ata_pci_device_do_resume() can return error code, all callers was updated
> except this one.
> 
> Signed-off-by: Monakhov Dmitriy <dmonakhov@...nvz.org>
> ---
>  drivers/ata/sata_inic162x.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
> index 31b636f..7933043 100644
> --- a/drivers/ata/sata_inic162x.c
> +++ b/drivers/ata/sata_inic162x.c
> @@ -639,7 +639,10 @@ static int inic_pci_device_resume(struct pci_dev *pdev)
>  	void __iomem *mmio_base = host->iomap[MMIO_BAR];
>  	int rc;
>  
> -	ata_pci_device_do_resume(pdev);
> +	rc = ata_pci_device_do_resume(pdev);
> +	if (rc) {
> +		return rc;

Either (a) don't use the braces when they are not needed, or
(b) is it possible to add a meaningful message there, or is that
done elsewhere?

> +	}
>  
>  	if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND) {
>  		printk("XXX\n");
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/