linux-kernel - [RFC][PATCH] intel8x0: revert regression that broke sounds after S3 suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <45E58D2D.6010308@ray.fi>
Date:	Wed, 28 Feb 2007 16:09:49 +0200
From:	Tommi Kyntola <tommi.kyntola@....fi>
To:	linux-kernel@...r.kernel.org, alsa-devel@...ts.sourceforge.net
Subject: [RFC][PATCH] intel8x0: revert regression that broke sounds after
 S3 suspend


The regression in 2.6.19-rc3 (namely 30b35399ceb2398d05837863476dcb12f12f3a82,
"[ALSA] Various fixes for suspend/resume of ALSA PCI drivers"),
broke HP nw8000 speaker sounds after S3 suspend (headphones still worked).
Removing this line makes the sounds work again...

Signed-off-by: Tommi Kyntola <tommi.kyntola@....fi>
---
This is a FYI kinda message, which Rafael Wysocki asekd me to send,
and something that is clearly not the correct way to go with this,
but I was unable to locate the actual reason for the regression
and this does fix it for me, so here it goes.

Wether other devices suffer from this or not, I don't know. I was only
able test this on an HP nw8000, which has the said intel8x0.

I'll gladly try out further patches or submit configs, or whatever
more verbose information is asked for.
         Kynde

diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index a289abf..f62a456 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -2470,7 +2470,6 @@ static int intel8x0_suspend(struct pci_dev *pci, pm_message_t state)
         }
         pci_disable_device(pci);
         pci_save_state(pci);
-       pci_set_power_state(pci, pci_choose_state(pci, state));
         return 0;
  }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/