linux-kernel - Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702281022380.12485@woody.linux-foundation.org>
Date:	Wed, 28 Feb 2007 10:28:10 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2

On Wed, 28 Feb 2007, Linus Torvalds wrote:
> 
> In other words, there is *zero* excuse for that braindamage.

To be clear:

 - in header files, we put "common definitions":

	* #defines
	* data structure declarations
	* external function and data declarations
	* inline functions ("nicer but otherwise equivalent to a #define")

 - but we do *not* put

	* actual real code
	* actual real data

   because those go into C files.

Yes, yes, all rules have exceptions, and sometimes we have ugly header 
files. For an example of a pre-existing ugly header file that breaks these 
rules, just look at <asm-i386/bugs.h> for example. Yeah, it only gets 
included from one place, but it *still* shouldn't have code in it. It grew 
over time, and none of the individual events were ever really big enough 
for anybody to say "ok, we should clean this up and create a bugs.c file 
in arch/i386/kernel".

I'm sure there are other examples of the exceptions too. But I do not want 
to add *new* ugly stuff, and I certainly refuse to do it after we're 
already long past a merge window.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/