linux-kernel - Re: Linux 2.6.21-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Feb 2007 08:39:26 +0100
From:	Brice Goglin <Brice.Goglin@...-lyon.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: Linux 2.6.21-rc2

Linus Torvalds wrote:
> Oh well.. I'm not very proud of this, because quite frankly, -rc2 has way 
> more changes than I really like.
>   

Hi Linus,

rc2 fails to build on my thinkpad t43:

  CC      arch/i386/kernel/io_apic.o
arch/i386/kernel/io_apic.c: In function 'setup_IO_APIC_irqs':
arch/i386/kernel/io_apic.c:1357: error: 'struct irq_desc' has no member
named 'affinity'
arch/i386/kernel/io_apic.c: In function 'io_apic_set_pci_routing':
arch/i386/kernel/io_apic.c:2878: error: 'struct irq_desc' has no member
named 'affinity'
make[1]: *** [arch/i386/kernel/io_apic.o] Error 1
make: *** [arch/i386/kernel] Error 2

The problem is caused by affinity being within #ifdef SMP in struct
irq_desc in irq.h:
#ifdef CONFIG_SMP
        cpumask_t               affinity;
        unsigned int            cpu;
#endif

I don't know whether the whole functions or just a single line should be
placed under #ifdef CONFIG_SMP. Eric (in CC) will know better than I do.

My config is attached.

Brice


View attachment "config" of type "text/plain" (47683 bytes)