linux-kernel - Re: [-mm patch] arch/i386/xen/: possible cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45E6B0A1.8090106@goop.org>
Date:	Thu, 01 Mar 2007 02:53:21 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Adrian Bunk <bunk@...sta.de>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] arch/i386/xen/: possible cleanups

Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - every file should #include the headers containing the prototypes for
>   it's global functions
>   - the xen_set_pud() prototype mismatch gcc was now able to detect
>     is corrected
> - make the following needlessly global variable static:
>   - events.c: virq_to_irq[]
> - make the following needlessly global functions static:
>   - setup.c: xen_idle()
>   - events.c: mask_evtchn()
>   - events.c: unmask_evtchn()
>   - mmu.c: xen_pgd_unpin()
> - remove the following unused variables:
>   - setup.c: pfn_to_mfn_frame_list
>   - setup.c: pfn_to_mfn_frame_list_list
> - #if 0 the following unused global function:
>   - mmu.c: xen_set_pte_atomic()
> - remove the following empty unused global functions:
>   - mmu.c: xen_pte_update()
>   - mmu.c: xen_pte_update_defer()
> - remove the following unused EXPORT_SYMBOL:
>   - setup.c: HYPERVISOR_shared_info
>   

Thanks Adrian.  I'd already done a lot of this locally, but I'll
double-check before posting.

>  struct shared_info *HYPERVISOR_shared_info = &init_shared;
> -EXPORT_SYMBOL(HYPERVISOR_shared_info);
>   

Are you sure?  I thought I added this because akpm was getting compile
errors with allmodconfig.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/