lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Mar 2007 12:47:35 +0100 From: Ingo Molnar <mingo@...e.hu> To: Evgeniy Polyakov <johnpol@....mipt.ru> Cc: Pavel Machek <pavel@....cz>, Theodore Tso <tytso@....edu>, Linus Torvalds <torvalds@...ux-foundation.org>, Ulrich Drepper <drepper@...hat.com>, linux-kernel@...r.kernel.org, Arjan van de Ven <arjan@...radead.org>, Christoph Hellwig <hch@...radead.org>, Andrew Morton <akpm@....com.au>, Alan Cox <alan@...rguk.ukuu.org.uk>, Zach Brown <zach.brown@...cle.com>, "David S. Miller" <davem@...emloft.net>, Suparna Bhattacharya <suparna@...ibm.com>, Davide Libenzi <davidel@...ilserver.org>, Jens Axboe <jens.axboe@...cle.com>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [patch 00/13] Syslets, "Threadlets", generic AIO support, v3 * Ingo Molnar <mingo@...e.hu> wrote: > > I also changed client socket to nonblocking mode with the same result > > in epoll server. If you will find it broken, please send me corrected > > to test too. > > this line in evserver_kevent.c looks a bit fishy: this one in evserver_kevent.c looks problematic too: shutdown(s, SHUT_RDWR); close(s); as evserver_epoll.c only does: close(s); again, there might be TCP control flow differences due to this. [ Or the removal of this shutdown() call might be a small speedup for the kevent case ;) ] Also, the order of fd and socket close() is different in the two cases. It shouldnt make any difference - but that too just makes the results harder to trust. Would it be so hard to introduce a single handle_web_request() function that is exactly the same in the two tests? All the queueing details (which are of course different in the epoll and the kevent case) should be in the client function, which calls handle_web_request(). Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists