lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070301130336.GB18853@strauss.suse.de>
Date:	Thu, 1 Mar 2007 14:03:36 +0100
From:	Bernhard Walle <bwalle@...e.de>
To:	linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel

* Bernhard Walle <bwalle@...e.de> [2007-03-01 13:57]:
> * Horms <horms@...ge.net.au> [2007-03-01 05:22]:
> > On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> > > Add a missing #define for the platform_kernel_launch_event.
> > > Without this fix, a call to platform_kernel_launch_event()
> > > becomes a noop on generic kernels. SN systems require this
> > > fix to successfully kdump/kexec from certain hardware errors.
> > >
> > > Signed-off-by: John Keller <jpk@....com>
> > 
> > I made a similar change when porting to xen, but I hadn't thought
> > to see if mainline linux needs it to.
> > 
> > Acked-by: Simon Horman <horms@...ge.net.au>
> 
> I think there's an additional change needed. Without that, it leads to
> a NULL pointer dereference.

Maybe I should also get my editor right ... ;):

---
 include/asm-ia64/machvec.h |    2 ++
 1 file changed, 2 insertions(+)

Index: b/include/asm-ia64/machvec.h
===================================================================
--- a/include/asm-ia64/machvec.h
+++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
 #  define platform_setup_msi_irq	ia64_mv.setup_msi_irq
 #  define platform_teardown_msi_irq	ia64_mv.teardown_msi_irq
 #  define platform_pci_fixup_bus	ia64_mv.pci_fixup_bus
+#  define platform_kernel_launch_event	ia64_mv.kernel_launch_event
 # endif
 
 /* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
 	platform_setup_msi_irq,			\
 	platform_teardown_msi_irq,		\
 	platform_pci_fixup_bus,			\
+	platform_kernel_launch_event            \
 }
 
 extern struct ia64_machine_vector ia64_mv;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ