linux-kernel - Re: minor device number request for /dev/kvm (kernel-based virtual machine)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45E6CF82.9090001@qumranet.com>
Date:	Thu, 01 Mar 2007 15:05:06 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
CC:	"Mathiasen, Torben" <Torben.Mathiasen@...com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	kvm-devel <kvm-devel@...ts.sourceforge.net>
Subject: Re: minor device number request for /dev/kvm (kernel-based virtual
 machine)

Jan Engelhardt wrote:
> On Mar 1 2007 13:58, Avi Kivity wrote:
>   
>> fs/char_dev.c:
>>     
>>> int register_chrdev(unsigned int major, const char *name,
>>>            const struct file_operations *fops)
>>> {
>>> struct char_device_struct *cd;
>>> struct cdev *cdev;
>>> char *s;
>>> int err = -ENOMEM;
>>>
>>> cd = __register_chrdev_region(major, 0, 256, name);
>>>       
>> So misc minor numbers under 256 are not supported.
>>
>> What's the way out?  Increase the region size?  I don't know if that's safe.
>>     
>
> If it does not increase memory usage, then possibly:
>
>   __register_chrdev_region(major, 0, (~0U) & MINORMASK, name);
>                                   or (1<<MINORMASK)-1 if that's more clear
>
>   

I'm more worried about something in the chardev bowels not supporting 
 >8bit minors well.


-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/