linux-kernel - Re: [PATCH] Fix soft lockup with iSeries viocd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070301003748.5a571916.akpm@linux-foundation.org>
Date:	Thu, 1 Mar 2007 00:37:48 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	tony@...eyournoodle.com (Tony Breeds)
Cc:	Linux Kernel ML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] Fix soft lockup with iSeries viocd driver

On Thu, 1 Mar 2007 14:56:40 +1100 tony@...eyournoodle.com (Tony Breeds) wrote:

> From: Tony Breeds <tony@...eyournoodle.com>
> 
> Fix soft lockup with iSeries viocd driver, caused by eventually calling
> end_that_request_first() with nr_bytes 0.
> 
> The lockup is triggered by hald, interrogating the device.
> 

What causes the lockup, and how does this patch fix it?

> 
> Index: linux-2.6.20-rc5/drivers/cdrom/viocd.c
> ===================================================================
> --- linux-2.6.20-rc5.orig/drivers/cdrom/viocd.c
> +++ linux-2.6.20-rc5/drivers/cdrom/viocd.c
> @@ -376,6 +376,25 @@ static int send_request(struct request *
>         return 0;
>  }
>  
> +static void viocd_end_request(struct request *req, int uptodate)
> +{
> +       int nsectors = req->hard_nr_sectors;

Your email client replaces tabs with spaces.  I fixed this patch up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/