linux-kernel - Re: [patch 2.6.21-rc2] gpio_keys driver shouldn't be ARM-specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703011654.18682.david-b@pacbell.net>
Date:	Thu, 1 Mar 2007 16:54:18 -0800
From:	David Brownell <david-b@...bell.net>
To:	Ben Nizette <ben.nizette@...et.net.au>
Cc:	Dmitry Torokhov <dtor@...l.ru>,
	pHilipp Zabel <philipp.zabel@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2.6.21-rc2] gpio_keys driver shouldn't be ARM-specific

On Thursday 01 March 2007 4:18 pm, Ben Nizette wrote:
> David Brownell wrote:
> > The gpio_keys driver is wrongly ARM-specific; it can't build on
> > other platforms with GPIO suport.  This fixes that problem.
> > 
> I did up a similar patch a few days back, you beat me too it ;).  I've 
> been using this driver on AVR32 for a while now.

I know various folk have been doing that very thing ...


> The other thing was that this driver only depends on the machine 
> supporting your generic GPIO conventions.  Currently the Kconfig entry 
> for gpio_keys reads:
> 
> 	depends on (ARCH_SA1100 || ARCH_PXA || ARCH_S3C2410)
> 
> With the || AVR32 I've added to my version it's getting a bit out of 
> hand!  Anyone else think it would be worth introducing a GPIO_FRAMEWORK 
> symbol selected by each machine which supports it and just set the 
> gpio_keys dependency to that?

Earlier today I posted a patch adding CONFIG_GENERIC_GPIO, and
I think that will get merged soonish ...

- Dave


> 
> Ben.
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/