linux-kernel - Re: usbserial not working/oops on removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Mar 2007 11:38:20 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Andreas Laumann <al@...hentidate.de>
Cc:	Kevin Fenzi <kevin@...ye.com>, linux-kernel@...r.kernel.org
Subject: Re: usbserial not working/oops on removal

Am Samstag, 3. März 2007 08:19 schrieb Andreas Laumann:
> Am Samstag, den 03.03.2007, 07:45 +0100 schrieb Oliver Neukum:
> > Am Samstag, 3. März 2007 03:37 schrieb Kevin Fenzi:
> > > I'm seeing some oddity with the latest fedora development kernel and a
> > > usbserial device. 
> > 
> > Very interesting. Is this repeatable? Does unplugging have the same effect?
> 
> I see it also on fedora rawhide using reinersct (cyberjack) scard
> readers and it repeatable.
> The first usbserial devices likes to register the line number 255 which
> indeed is invalid.

OK, please try this patch.

	Regards
		Oliver

--- linux-2.6.21-rc1/drivers/usb/serial/usb-serial.c.alt	2007-02-21 05:32:30.000000000 +0100
+++ linux-2.6.21-rc1/drivers/usb/serial/usb-serial.c	2007-02-26 15:32:50.000000000 +0100
@@ -826,7 +826,6 @@
 			num_ports = type->num_ports;
 	}
 
-	serial->minor = minor;
 	serial->num_ports = num_ports;
 	serial->num_bulk_in = num_bulk_in;
 	serial->num_bulk_out = num_bulk_out;
@@ -980,6 +979,7 @@
 		dev_err(&interface->dev, "No more free serial devices\n");
 		goto probe_error;
 	}
+	serial->minor = minor;
 
 	/* register all of the individual ports with the driver core */
 	for (i = 0; i < num_ports; ++i) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/