linux-kernel - Re: [PATCH] bcm43xx: do not rebuild when kernel version changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Mar 2007 22:10:31 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Larry Finger <larry.finger@...inger.net>
Cc:	Sam Ravnborg <sam@...nborg.org>, linux-wireless@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] bcm43xx: do not rebuild when kernel version changes

On Saturday 03 March 2007 22:03, Larry Finger wrote:
> Michael Buesch wrote:
> > On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
> >> Replacing use of UTS_RELEASE with utsname()->release
> >> avoids that this module is rebuild each
> >> time the kernel version changes.
> >>
> >> Compile tested only.
> > 
> > I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> > It will vanish with the advent of d80211, anyway.
> > Larry?
> 
> Is bcm43xx_ethtool.c really useless?

Yes it is useless.
1) There isn't really anything ethtool related implemented. Just the useless info stuff.
2) ethtool is rather useless for wireless in general (that's why there isn't
   anything implemented ;) )

Please remove the file, kill it from Makefile and remove the ethtool
ops set in main.c (one line).

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/