linux-kernel - Re: [PATCH 1/2] x86_64: add reporting of SVM flags to /proc/cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070305150625.GJ30318@amd.com>
Date:	Mon, 5 Mar 2007 16:06:25 +0100
From:	"Joerg Roedel" <joerg.roedel@....com>
To:	"Michael Tokarev" <mjt@....msk.ru>
cc:	discuss@...-64.org, "Andi Kleen" <ak@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86_64: add reporting of SVM flags to
 /proc/cpuinfo

On Mon, Mar 05, 2007 at 05:46:27PM +0300, Michael Tokarev wrote:
> Joerg Roedel wrote:
> > +++ b/arch/x86_64/kernel/setup.c
> > +	static char *x86_svm_flags[] = {
> > +		"npt",
> > +		"lbrv",
> > +		"svmlock",
> > +	};
> 
> A nitpick:
> 
> static const char *const x86_svm_flags[] = ... ?

Right. Its better to mark the array as const. Will wait
for more comments and send an updated patch soon.

Thanks,
Joerg

-- 
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/