linux-kernel - RE: [PATCH] xfrm_policy delete security check misplaced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Mar 2007 09:33:27 -0600
From:	"Venkat Yekkirala" <vyekkirala@...stedCS.com>
To:	"'Eric Paris'" <eparis@...isplace.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Cc:	<davem@...emloft.net>, <jamesm@...ei.org>,
	"Venkat Yekkirala" <vyekkirala@...fw4.tcs-sec.com>,
	<cxzhang@...son.ibm.com>, <sds@...ho.nsa.gov>,
	<latten@...tin.ibm.com>
Subject: RE: [PATCH] xfrm_policy delete security check misplaced

> @@ -2552,7 +2550,7 @@ static int pfkey_spdget(struct sock 
> *sk, struct sk_buff *skb, struct sadb_msg *h
>  		return -EINVAL;
>  
>  	xp = xfrm_policy_byid(XFRM_POLICY_TYPE_MAIN, dir, 
> pol->sadb_x_policy_id,
> -			      hdr->sadb_msg_type == SADB_X_SPDDELETE2);
> +			      hdr->sadb_msg_type == 
> SADB_X_SPDDELETE2, &err);
>  	if (xp == NULL)
>  		return -ENOENT;
I guess you meant to do this here?
	else if (err)
		return err;

Also, [Joy cc'd] deletions here needn't be audited?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/