linux-kernel - RE: [PATCH] xfrm_policy delete security check misplaced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1173113488.31047.36.camel@localhost.localdomain>
Date:	Mon, 05 Mar 2007 11:51:28 -0500
From:	Eric Paris <eparis@...isplace.org>
To:	James Morris <jmorris@...ei.org>
Cc:	Venkat Yekkirala <vyekkirala@...stedCS.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Venkat Yekkirala <vyekkirala@...fw4.tcs-sec.com>,
	cxzhang@...son.ibm.com, Stephen Smalley <sds@...ho.nsa.gov>
Subject: RE: [PATCH] xfrm_policy delete security check misplaced

On Mon, 2007-03-05 at 11:39 -0500, James Morris wrote:
> On Mon, 5 Mar 2007, Venkat Yekkirala wrote:
> 
> > > 
> > > Signed-off-by: Eric Paris <eparis@...hat.com>
> > Acked-by: Venkat Yekkirala <vyekkirala@...stedcs.com> 
> 
> What about your previous comment:
> 
>  "I guess you meant to do this here?
>         else if (err)
>                 return err; "

That also gets taken care of in the pfkey_spdget cleanup in a later
patch.  The return isn't in that same place venkat suggested it instead
happens inside the new if (delete) block.  (err is only non-zero on
delete operations so there is no need to check it otherwise)

-Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/