linux-kernel - Re: [S390] Use generic bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070305.145629.28789919.davem@davemloft.net>
Date:	Mon, 05 Mar 2007 14:56:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	schwidefsky@...ibm.com
Cc:	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	heiko.carstens@...ibm.com
Subject: Re: [S390] Use generic bug.

From: Martin Schwidefsky <schwidefsky@...ibm.com>
Date: Mon, 5 Mar 2007 23:43:54 +0100

> +	if (__builtin_constant_p(__ret_warn_on)) {	\
> +		if (__ret_warn_on)			\
> +			__EMIT_BUG(BUGFLAG_WARNING);	\

I see we'll have this construct on powerpc, parisc and now s390.

But if it's going to trigger essentially at compile time, I
think it's much better to BUILD_BUG_ON() in this case instead
of counting on the code path to actually run and the user to
notice and report the kernel log message.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/