linux-kernel - Re: [PATCH] fs: nobh_truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 Mar 2007 17:10:11 -0600
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Will Trives <will@...vescon.com.au>,
	linux-kernel@...r.kernel.org,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Chuck Ebbert <cebbert@...hat.com>
Subject: Re: [PATCH] fs: nobh_truncate_page() fix

On Mon, 2007-03-05 at 14:57 -0800, Andrew Morton wrote:
> Is OK, I think.  nobh_prepare_write() brings the outside-from-and-to
> sections of the page uptodate and memset in nobh_truncate_page() brings the
> rest of the page uptodate.
> 
> We bring the to->PAGE_CACHE_SIZE section uptodate twice, which could be
> optimised.

Why not have nobh_truncate_page() call prepare_write() with to =
PAGE_CACHE_SIZE?  I don't really grok:

to = (offset + blocksize) & ~(blocksize - 1);
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/