[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d4poyvfdq.fsf@Hurtta06k.keh.iki.fi>
Date: 06 Mar 2007 12:24:33 +0200
From: Kari Hurtta <hurtta+gmane@...lo.fmi.fi>
To: linux-kernel@...r.kernel.org
Cc: linux-mm@...ck.org
Subject: Re: [PATCH 3/3][RFC] Containers: Pagecache controller reclaim
Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com> writes
in gmane.linux.kernel,gmane.linux.kernel.mm:
> --- linux-2.6.20.orig/mm/pagecache_acct.c
> +++ linux-2.6.20/mm/pagecache_acct.c
> @@ -29,6 +29,7 @@
> #include <linux/uaccess.h>
> #include <asm/div64.h>
> #include <linux/pagecache_acct.h>
> +#include <linux/memcontrol.h>
>
> /*
> * Convert unit from pages to kilobytes
> @@ -337,12 +338,20 @@ int pagecache_acct_cont_overlimit(struct
> return 0;
> }
>
> -extern unsigned long shrink_all_pagecache_memory(unsigned long nr_pages);
> +extern unsigned long shrink_container_memory(unsigned int memory_type,
> + unsigned long nr_pages, void *container);
>
> int pagecache_acct_shrink_used(unsigned long nr_pages)
> {
> unsigned long ret = 0;
> atomic_inc(&reclaim_count);
> +
> + /* Don't call reclaim for each page above limit */
> + if (nr_pages > NR_PAGES_RECLAIM_THRESHOLD) {
> + ret += shrink_container_memory(
> + RECLAIM_PAGECACHE_MEMORY, nr_pages, NULL);
> + }
> +
> return 0;
> }
>
'ret' is not used ?
/ Kari Hurtta
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists