linux-kernel - RE: [patch 1/1] ppc: Possible bug fix for FCC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00B1F4365DDBE745B091C67A1CCFCB4307124DB1@zctfhxm1>
Date:	Tue, 6 Mar 2007 12:03:57 +0100
From:	"Cedric Pontois" <cpontois@...tel.com>
To:	"Vitaly Bordug" <vbordug@...mvista.com>,
	"Li Yang-r58472" <LeoLi@...escale.com>
Cc:	<dmalek@....net>, <linux-kernel@...r.kernel.org>,
	<linuxppc-embedded@...abs.org>, "Rachid Koucha" <koucha@...tel.com>
Subject: RE: [patch 1/1] ppc: Possible bug fix for FCC driver

Hi Vitaly,

The problem seems to be similar in recent kernels
(/drivers/net/fs_enet/mac-fcc.c). The transmit clock is inverted (TCI
bit set). The packets are well received, transmitted packets go out (tx
counter is ok), unfortunately as the clock is inverted (TCI) the data
are not correctly received by the other side. The FCC works in 100Mbps
(luck?) but doesn't in 10Mbps. I solved this problem by removing the TCI
bit set as described in the patch. Actually, this problem depends also
of the Ethernet phy used on board.

Cedric

-----Original Message-----
From: Vitaly Bordug [mailto:vbordug@...mvista.com] 
Sent: mardi 6 mars 2007 10:42
To: Li Yang-r58472
Cc: Pontois, Cedric UMTS (CEZ:8Z10); dmalek@....net;
linux-kernel@...r.kernel.org; linuxppc-embedded@...abs.org
Subject: Re: [patch 1/1] ppc: Possible bug fix for FCC driver


On Tue, 6 Mar 2007 10:23:43 +0800
Li Yang-r58472 wrote:

> Hi Cedric,
> 
> For ppc embedded related patches, please also cc: 
> linuxppc-embedded@...abs.org.
> 
> > We use a kernel 2.6.14 on PPC platform (MPC 8555). The FCC driver
> works
> 
> To submit a kernel patch upstream, the patch should be against the 
> latest kernel version which is 2.6.21-rc now.
> > well with a 100Mbps link. But it doesn't with a 10Mbps link. To 
> > solve it, I modified the GFMR register init: removed TCI bit and set

> > CRC32
> bit
> > instead of.
> 
> I don't know how these bits caused the 10M link issue.  Do you have 
> any reasoning?
> 
> > 	Signed-off-by: Cedric Pontois <cpontois@...tel.com>
> > 
> >
> ----------------------------------------------------------------------
> --
> > -----
> > 
> > diff -ruN pa-original/arch/ppc/8260_io/fcc_enet.c
The fcc code in 8260_io has been obsoleted by fs_enet driver
(drivers/net/fs_enet). It is known to work with 85xx at least in recent
kernels. If it does not for some reason, please letus know.

Thanks,

-Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/