linux-kernel - Re: [PATCH 1/8] Remove cpu_gdt_table: use boot_gdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Mar 2007 14:26:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Zachary Amsden <zach@...are.com>,
	Jeremy Fitzhardinge <jeremy@...source.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...e.de>
Subject: Re: [PATCH 1/8] Remove cpu_gdt_table: use boot_gdt_table until migration to per-cpu


* Ingo Molnar <mingo@...e.hu> wrote:

> > +	.quad 0x00cf9a000000ffff	/* boot: 4GB code at 0x00000000 */
> > +	.quad 0x00cf92000000ffff	/* boot: 4GB data at 0x00000000 */
> >  	.quad 0x0000000000000000	/* 0x20 unused */
> >  	.quad 0x0000000000000000	/* 0x28 unused */
> >  	.quad 0x0000000000000000	/* 0x33 TLS entry 1 */
> 
> actually, the reason for the small boot GDT was that some systems 
> wouldnt even boot with a larger GDT. (there was some BIOS interaction, 
> forgot what it was - iirc it was mach-visws and also some other older 
> box)
> 
> the 'simplification' you do here is actually how Linux worked before 
> it was fixed for those systems.
> 
> so i'd be quite nervous to touch this area of the GDT code. (I'd 
> support a renaming though, gdt_table is indeed ugly.)

and this seems to have a ripple effect on the rest of your GDT changes - 
i'll wait for this to be cleared before doing a line by line review of 
them. I commented on the mostly-unaffected ones already.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/