linux-kernel - Re: [PATCH] ocfs2: fix module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <961aa3350703060838i244469e2g7b10737343398b45@mail.gmail.com>
Date:	Wed, 7 Mar 2007 01:38:17 +0900
From:	"Akinobu Mita" <akinobu.mita@...il.com>
To:	"Akinobu Mita" <akinobu.mita@...il.com>,
	linux-kernel@...r.kernel.org,
	"Mark Fasheh" <mark.fasheh@...cle.com>,
	"Kurt Hackel" <kurt.hackel@...cle.com>
Subject: Re: [PATCH] ocfs2: fix module_init error handling

2007/3/6, Joel Becker <Joel.Becker@...cle.com>:
> On Sun, Mar 04, 2007 at 10:34:43PM +0900, Akinobu Mita wrote:
> > From: Akinobu Mita <akinobu.mita@...il.com>
> > Subject: [PATCH] ocfs2: fix module_init error handling
> >
> > Fix error handling in module_init and make module_init() return
> > correct error code.
>
>         What are you fixing specifically?  This looks like you are
> reorganizing the exit path.  While stylistic differences can exist on
> the choice of function exit, claiming there is a "fix" means there is an
> actual bug.  Please clarify the bug so we can evaluate your change.

OK. There are three problems (these are not likely to happen)

- There is no error handling when register_filesystem() fails
  (several slab caches, debugfs directory, and workqueue will not be cleaned)

- workqueue will not be cleaned if debugfs_create_dir() returns error.

- kmem_cache_destroy() with NULL oops will happen if
  ocfs2_free_mem_caches(), exit_ocfs2_uptodate_cache(),
  or exit_ocfs2_extent_maps() return error.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/