linux-kernel - Re: [PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45EDCD35.80301@simon.arlott.org.uk>
Date:	Tue, 06 Mar 2007 20:21:09 +0000
From:	Simon Arlott <simon@...e.lp0.eu>
To:	Marcel Holtmann <marcel@...tmann.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Harald Welte <laforge@...monks.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver

On 06/03/07 21:12, Marcel Holtmann wrote:
> Hi Linus,
> 
> the attached patch fixes a buffer overflow in the Omnikey CardMan 4040
> driver that could lead to a potential arbitrary code execution with
> kernel privileges.
> 
> Regards
> 
> Marcel
> 

-	if (count < 5) {
+	if ((count < 5) || (count > READ_WRITE_BUFFER_SIZE)) {
 		DEBUGP(2, dev, "<- cm4040_write buffersize=%Zd < 5\n", count);
 		return -EIO;
 	}

That debug message needs to be changed too since count won't always 
be < 5 when it's used.

-- 
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/