lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Mar 2007 15:56:49 +0100 From: Andi Kleen <ak@...e.de> To: Roland Dreier <rdreier@...co.com> Cc: Ingo Molnar <mingo@...e.hu>, Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Arjan van de Ven <arjan@...radead.org>, Adrian Bunk <bunk@...sta.de>, Alan Cox <alan@...rguk.ukuu.org.uk> Subject: Re: [patch] disable NMI watchdog by default On Wednesday 07 March 2007 04:06, Roland Dreier wrote: > > --- linux.orig/include/asm-x86_64/nmi.h > > +++ linux/include/asm-x86_64/nmi.h > > @@ -63,7 +63,7 @@ extern int setup_nmi_watchdog(char *); > > > > extern atomic_t nmi_active; > > extern unsigned int nmi_watchdog; > > -#define NMI_DEFAULT -1 > > +#define NMI_DEFAULT 0 > > Maybe I'm missing something obvious, but this patch doesn't seem > correct to me. The sentiment of disabling the NMI watchdog by default > is fine, and I agree with it, but I don't think this patch does what > it says. First of all, I have a system running a kernel with this > patch applied (v2.6.21-rc2-gc3442e2), and I see NMIs in > /proc/interrupts and "testing NMI watchdog ... OK." in the log. Yes the patch looks quite broken. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists