linux-kernel - Re: ALIGN via ilog2 without gccisms (Re: [PATCH] Fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703070836220.5963@woody.linux-foundation.org>
Date:	Wed, 7 Mar 2007 08:38:27 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Oleg Verych <olecom@...wer.upol.cz>
cc:	David Howells <dhowells@...hat.com>,
	Al Viro <viro@....linux.org.uk>, akpm@...ux-foundation.org,
	benh@...nel.crashing.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, johannes@...solutions.net
Subject: Re: ALIGN via ilog2 without gccisms (Re: [PATCH] Fix get_order())



On Wed, 7 Mar 2007, Oleg Verych wrote:
>
> Probably it can be used to get rid of gccisms and "type fluff" due to
> bitwise arithmetics in ALIGN?

Hell no.

The typeof is there to make sure we have the right type, and it's simple.

The current ALIGN() macro is efficient as hell (generating just a simple 
mask+add). Turning it into some kind of horrible thing that uses ilog2() 
would be a total mistake.

Also, your ALIGN() macro was broken. That's not how ALIGN() is supposed to 
work.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/