linux-kernel - Re: [patch 00/12] Syslets, Threadlets, generic AIO support, v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070307201018.GA8485@kryten>
Date:	Wed, 7 Mar 2007 14:10:18 -0600
From:	Anton Blanchard <anton@...ba.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@....com.au>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Ulrich Drepper <drepper@...hat.com>,
	Zach Brown <zach.brown@...cle.com>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	"David S. Miller" <davem@...emloft.net>,
	Suparna Bhattacharya <suparna@...ibm.com>,
	Davide Libenzi <davidel@...ilserver.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch 00/12] Syslets, Threadlets, generic AIO support, v5


Hi Ingo,

> this is the v5 release of the syslet/threadlet subsystem:
> 
>    http://redhat.com/~mingo/syslet-patches/

Nice!

I tried to port this to ppc64 but found a few problems:

The 64bit powerpc ABI has the concept of a TOC (r2) which is used for
per function data. This means this wont work:

        if (ah->restore_stack) {
                set_task_stack_reg(new_task, ah->restore_stack);
                task_ip_reg(new_task) = ah->restore_ip;
                /*
                 * The return code 0 is needed to tell the
                 * head user-context that the threadlet went async:
                 */
                task_ret_reg(new_task) = 0;
        }

I think we would want to change restore_ip to restore_function, and then
create a per arch helper, perhaps:

void set_user_context(struct task_struct *task, unsigned long stack,
		      unsigned long function, unsigned long retval);

ppc64 could then grab the ip and r2 values from the function descriptor.

The other issue involves the syscall table:

asmlinkage struct syslet_uatom __user *
sys_async_exec(struct syslet_uatom __user *uatom,
               struct async_head_user __user *ahu)
{
        return __sys_async_exec(uatom, ahu, sys_call_table, NR_syscalls);
}

This exposes the layout of the syscall table. Unfortunately it wont work
on ppc64. In arch/powerpc/kernel/systbl.S:

#define COMPAT_SYS(func)        .llong  .sys_##func,.compat_sys_##func

Both syscall tables are overlaid.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/