linux-kernel - Re: [PATCH] drivers: PMC MSP71xx GPIO char driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <45EF4F0E.50303@pmc-sierra.com>
Date:	Wed, 7 Mar 2007 15:47:26 -0800 
From:	Marc St-Jean <Marc_St-Jean@...-sierra.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Marc St-Jean <stjeanma@...-sierra.com>,
	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH] drivers: PMC MSP71xx GPIO char driver

Andrew Morton wrote:
>  > On Fri, 23 Feb 2007 17:28:19 -0600 Marc St-Jean 
> <stjeanma@...-sierra.com> wrote:
>  > [PATCH] drivers: PMC MSP71xx GPIO char driver
>  >
>  > Patch to add a GPIO char driver for the PMC-Sierra
>  > MSP71xx devices.
>  >
>  > This patch references some platform support files previously
>  > submitted to the linux-mips@...ux-mips.org list.
>  >

Thanks for the feedback Andrew. I've implemented all your recommendations
other than the kernel thread handling, which I still have to look into.

[...]

> 
>  > +/* -- Module functions -- */
>  > +
>  > +static int msp_gpio_blinkthread( void *none )
> 
> Why is this a "module function"?

The reason is likely because it's only called by msp_gpio_init so it was
considered part of the module code. I'll move the comment to only cover
msp_gpio_init/exit.

[...]

>  > +module_init(msp_gpio_init);
>  > +module_exit(msp_gpio_exit);
>  > +
>  > +EXPORT_SYMBOL(msp_gpio_in);
>  > +EXPORT_SYMBOL(msp_gpio_out);
>  > +EXPORT_SYMBOL(msp_gpio_mode);
>  > +EXPORT_SYMBOL(msp_gpio_blink);
>  > +EXPORT_SYMBOL(msp_gpio_noblink);
> 
> What uses these exports?

These exports are needed for other drivers compiled as modules can control
the GPIO pins through this driver.

[...]

Marc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/