[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0703061942000.5963@woody.linux-foundation.org>
Date: Tue, 6 Mar 2007 19:43:50 -0800 (PST)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Yinghai Lu <yinghai.lu@....com>
cc: ebiederm@...ssion.com, Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
Andi Kleen <ak@...e.de>
Subject: Re: [PATCH] x86_64 irq: keep consistent for changing IRQ0_VECTOR
from 0x20 to 0x30
On Mon, 5 Mar 2007, Yinghai Lu wrote:
>
> please check the patch
Hmm.. It doesn't look *wrong*, but could you please
- split it up a bit (some of it is 100% obvious, ie the comment fixes)
- write an explanation for the individually split up patches
- not use attachments, but just make it inline. It's practically
impossible to reply and quote part of the patch now.
Eric/Ingo - did you go through and check the patch?
Thanks,
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists