linux-kernel - Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45EE42BC.6030209@debian.org>
Date:	Tue, 06 Mar 2007 23:42:36 -0500
From:	Andres Salomon <dilinger@...ian.org>
To:	Dave Jones <davej@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andres Salomon <dilinger@...ian.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set
 in setup.c

Dave Jones wrote:
> On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote:
>  > On Tue, 06 Mar 2007 18:52:59 -0500
>  > Andres Salomon <dilinger@...ian.org> wrote:
>  > 
>  > > If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined,
>  > > and setup.c won't compile.  This wraps it with an #ifdef.
>  > > 
>  > 
>  > I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly
>  > discover that.  But I don't think we need to "fix" it yet?

Oh, it's certainly not urgent.  I sent it simply for correctness reasons.

It would've been nice to see the ZONE_DMA removal patches just #define
ZONE_DMA regardless, and include less #ifdefs scattered about; but at
this point, I'd just as soon prefer to see a proper way to allocate
things based on address constraints (as discussed in
http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html).


> 
> CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how
> you could hit this compile failure.
> 

Why, with custom code of course ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/