linux-kernel - Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1HPGMB-0002AG-00@gondolin.me.apana.org.au>
Date:	Thu, 08 Mar 2007 22:00:23 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	jarkao2@...pl (Jarek Poplawski)
Cc:	simon@...ott.org, linux-kernel@...r.kernel.org, sri@...ibm.com,
	netdev@...r.kernel.org, lksctp-developers@...ts.sourceforge.net
Subject: Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

Jarek Poplawski <jarkao2@...pl> wrote:
> On 25-02-2007 10:08, Simon Arlott wrote:
>> This happens on every boot if more information is needed:
>> 
>> [   37.393715] =================================
>> [   37.393830] [ INFO: inconsistent lock state ]
>> [   37.393881] 2.6.21-rc1-git #146
>> [   37.393929] ---------------------------------
>> [   37.393979] inconsistent {softirq-on-R} -> {in-softirq-W} usage.
>> [   37.394040] hotplug/1072 [HC0[0]:SC1[2]:HE1:SE0] takes:
>> [   37.394092]  (&ndev->lock){-+-?}, at: [<b04a7944>] ipv6_add_addr+0x164/0x1e0
>> [   37.394308] {softirq-on-R} state was registered at:
>> [   37.394359]   [<b013fc42>] __lock_acquire+0x622/0xbb0
>> [   37.394515]   [<b0140652>] lock_acquire+0x62/0x80
>> [   37.394678]   [<b0511c65>] _read_lock+0x35/0x50
>> [   37.394834]   [<b050e200>] sctp_v6_copy_addrlist+0x30/0xc0
> ...
> 
> [SCTP] ipv6: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist
> 
> lockdep found that dev->lock taken from softirq in ipv6_add_addr
> is also taken in sctp_v6_copy_addrlist with softirqs enabled, so
> lockup is possible.

Who's calling ipv6_add_addr from softirq context? That's got to be
wrong because ipv6_add_addr requires the RTNL.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/