[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0703090647470.20037@williams.orchestra.cse.unsw.EDU.AU>
Date: Fri, 9 Mar 2007 07:01:30 +1100 (EST)
From: Kandan Venkataraman <kven709@....unsw.EDU.AU>
To: Jari Ruusu <jariruusu@...rs.sourceforge.net>
cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] Loop device - Tracking page writes made to a loop
devicethrough mmap
On Thu, 8 Mar 2007, Jari Ruusu wrote:
> Kandan Venkataraman wrote:
>> All comments have been taken care of.
>
> Your patch still does not do conversions of existing user space visible
> 'struct loop_info64' which is pretty much cast in stone. Blindly overwriting
> larger structure over smaller user space buffer of existing userspace
> binaries is the wrong way to do this.
Which of the two options below would be the best way
to get around this problem.
i)A new ioctl call to set/unset lo_track_pgwrite.
ii) Create 'struct loop_info64_v2' with
lo_track_pgwrite in it and two new ioctls LOOP_SET_STATUS64_V2
and LOOP_GET_STATUS64_V2.
Either way 'struct loop_info64' would be left untouched.
Please comment.
>
> There was a time when folks at least pretended that breaking user space ABI
> was not tolerable.
>
> --
> Jari Ruusu 1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9 DB 1D EB E3 24 0E A9 DD
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists