linux-kernel - Re: swsusp: platform notifications not properly undone in case of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200703082258.55186.rjw@sisk.pl>
Date:	Thu, 8 Mar 2007 22:58:54 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: swsusp: platform notifications not properly undone in case of error

On Thursday, 8 March 2007 17:41, Pavel Machek wrote:
> Hi!
> 
> 
> Using IPI No-Shortcut mode
> swsusp: Resume From Partition /dev/sda1
> PM: Checking swsusp image.
> swsusp: Signature found, resuming
> PM: Preparing processes for restore.
> Stopping tasks ... done.
> PM: Reading swsusp image.
> Loading image data pages (125285 pages) ...     <3>swsusp: Resume
> mismatch: version
> Read 501140 kbytes in 0.01 seconds (50114.00 MB/s)
> swsusp: Error -1 resuming
> PM: Restore failed, recovering.
> Restarting tasks ... done.
> PM: Resume from disk failed.
> md: Autodetecting RAID arrays.
> 
> ...and machine boots, but moon icon keeps blinking.

Does the appended patch help?

Rafael

---
 kernel/power/disk.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.21-rc3/kernel/power/disk.c
===================================================================
--- linux-2.6.21-rc3.orig/kernel/power/disk.c
+++ linux-2.6.21-rc3/kernel/power/disk.c
@@ -261,6 +261,7 @@ static int software_resume(void)
 	error = swsusp_read();
 	if (error) {
 		swsusp_free();
+		platform_finish();
 		goto Thaw;
 	}
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/