linux-kernel - Re: [PATCH 11/20] x86_64: wakeup.S misc cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Mar 2007 09:59:08 +0530
From:	Vivek Goyal <vgoyal@...ibm.com>
To:	Pavel Machek <pavel@....cz>
Cc:	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Reloc Kernel List <fastboot@...ts.osdl.org>,
	ebiederm@...ssion.com, akpm@...ux-foundation.org, ak@...e.de,
	hpa@...or.com, magnus.damm@...il.com, lwang@...hat.com,
	dzickus@...hat.com, rjw@...k.pl
Subject: Re: [PATCH 11/20] x86_64: wakeup.S misc cleanups

On Wed, Mar 07, 2007 at 11:41:57PM +0100, Pavel Machek wrote:
> Hi!
> 
> > +	movw	$0x0e00 + 'i', %ds:(0xb8012)
> > +	movb	$0xa8, %al	;  outb %al, $0x80;
> > +
> 
> > -	movw	$0x0e00 + 'i', %ds:(0xb8012)
> > -	movb	$0xa8, %al	;  outb %al, $0x80; 	
> 
> Outbs were my debugging hacks, perhaps you can simply remove them at
> this point? Not sure how useful "Linux" debug print is, it can
> probably be removed, too.
> 

Hi Pavel,

I found these debugging hacks useful while debugging some problem with 
my changes in this code. It helps to find out till what poing code flow
as reached in this assembly code. So I think its not a bad idea to let
this piece code be there.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/