| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20070308231833.69b0611e.amit2030@gmail.com> Date: Thu, 8 Mar 2007 23:18:33 -0800 From: Amit Choudhary <amit2030@...il.com> To: Linux Kernel <linux-kernel@...r.kernel.org> Subject: [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value. Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c. Signed-off-by: Amit Choudhary <amit2030@...il.com> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 021be39..91d474b 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -475,6 +475,14 @@ static int mos7840_get_reg(struct moschi int ret = 0; buffer = (__u8 *) mcs->ctrl_buf; + /* The memory for ctrl_buf is allocated in + * mos7840_startup(), but it is not checked if + * kmalloc failed. So, mcs->ctrl_buf might be NULL. + * So, it should be checked here. + */ + if (!buffer) + return -ENOMEM; + // dr=(struct usb_ctrlrequest *)(buffer); dr = (void *)(buffer + 2); dr->bRequestType = MCS_RD_RTYPE; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists