linux-kernel - Re: [BUG] ATAPI command TEST_UNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45F15A28.5010700@gmail.com>
Date:	Fri, 09 Mar 2007 21:59:20 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Conke Hu <conke.hu@...il.com>
CC:	Jeff Garzik <jeff@...zik.org>, Alan <alan@...rguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] ATAPI command TEST_UNIT_READY never succeeds!

Conke Hu wrote:
> On 3/7/07, Tejun Heo <htejun@...il.com> wrote:
>> (snip)
>> I've read your last posting about this, but forgot to follow up.  TUR is
>> supposed to fail if ATAPI device doesn't have media loaded.  TUR fails
>> and sense data returns device not ready - media not present.  That's the
>> normal operation.  Does TUR fail even with media loaded or is sense data
>> not properly fetched?
>>
> 
> Thank you, Tejun! I did forget to load any media :(
> When I load media and retry, TUR succeeds but there is still a
> problem: when using ahci driver, TUR will not succeed unless it runs
> twice, and the following loop always runs till retries==2
> -------------------- code in sr.c, get_capabilities()
> -------------------------
>     retries = 0;
>     do {
>         memset((void *)cmd, 0, MAX_COMMAND_SIZE);
>         cmd[0] = TEST_UNIT_READY;
> 
>         the_result = scsi_execute_req (cd->device, cmd, DMA_NONE, NULL,
>                            0, &sshdr, SR_TIMEOUT,
>                            MAX_RETRIES);
> 
>         retries++;
>     } while (retries < 5 &&
>          (!scsi_status_is_good(the_result) ||
>           (scsi_sense_valid(&sshdr) &&
>            sshdr.sense_key == UNIT_ATTENTION)));
> ------------------------------------- end code
> -------------------------------------
> 
> this issue only occurs in ahci driver,  and libata + pata driver is OK.

After media is loaded, it takes some time for the device to get ready,
and it's supposed to raise UNIT_ATTENTION to tell the driver that media
has changed.  TUR fails with UA and sense data reports media exchanged
and the next TUR succeeds.  In SATA, you might also see unit reset UA
due to the probing sequence.  Those are why TUR is tried several times
in the first place.

So, there's nothing wrong with failing TURs, it's perfectly normal that
they fail first one or two tries.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/