| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Mar 2007 21:48:07 +0100 From: Oliver Neukum <oneukum@...e.de> To: Alan Stern <stern@...land.harvard.edu> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Maneesh Soni <maneesh@...ibm.com>, gregkh@...e.de, linux-kernel@...r.kernel.org Subject: Re: refcounting drivers' data structures used in sysfs buffers Am Freitag, 9. März 2007 21:08 schrieb Alan Stern: > After some more thought, I basically agree with what Oliver wrote > originally. sysfs_dirent is indeed the logical place to store the kref > pointer. However it needs to be used during open and release, not during OK. > read, write, and poll. Another point, which Oliver didn't think of, is > that the kref pointer needs to be passed to the driver as an argument in > the show() and store() method calls. Why? What's wrong with simply calling kref_get/put? > Finally, there's added complexity in each driver which wants to use the > new facility. The module_exit routine will need to be smart enough to > block until all the private data structures have been released. > usb-storage does something like that now; it's kind of ugly (although it > could be improved if appropriate support were added to the core kernel). If we up the module count for every bound device, all device attributes should be gone before we ever get that far. Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists