[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070309221300.GB1818@elf.ucw.cz>
Date: Fri, 9 Mar 2007 23:13:00 +0100
From: Pavel Machek <pavel@....cz>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend
Hi!
> > > Index: linux-2.6.21-rc3/kernel/power/user.c
> > > ===================================================================
> > > --- linux-2.6.21-rc3.orig/kernel/power/user.c
> > > +++ linux-2.6.21-rc3/kernel/power/user.c
> > > @@ -402,9 +402,10 @@ static int snapshot_ioctl(struct inode *
> > >
> > > case PMOPS_ENTER:
> > > if (data->platform_suspend) {
> > > + disable_nonboot_cpus();
> > > kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK);
> > > error = pm_ops->enter(PM_SUSPEND_DISK);
> > > - error = 0;
> > > + enable_nonboot_cpus();
> >
> > Why did we discard return code in previous versions? Do we still want
> > to do that?
>
> I think it was a mistake.
I took a look at git-annotate, and it is yours code, so I assume you
are right. ACK, then.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists