linux-kernel - Re: [patch 2/5] signalfd v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703081820040.3670@alien.or.mcafeemobile.com>
Date:	Thu, 8 Mar 2007 18:22:00 -0800 (PST)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [patch 2/5] signalfd v4 - signalfd core ...

On Thu, 8 Mar 2007, Davide Libenzi wrote:

> +static ssize_t signalfd_read(struct file *file, char *buf, size_t count,
> +			     loff_t *ppos)
> +{
> +	struct signalfd_ctx *ctx = file->private_data;
> +	struct sighand_struct *sighand = ctx->sighand;
> +	ssize_t res = 0;
> +	int signo = 0;
> +	siginfo_t info;
> +	DECLARE_WAITQUEUE(wait, current);
> +
> +	if (count < sizeof(struct signalfd_siginfo))
> +		return -EINVAL;
> +	spin_lock_irq(&sighand->siglock);
> +	if (unlikely(sighand != ctx->tsk->sighand))
> +		goto out_unlock;
> +	res = -EAGAIN;
> +	if ((signo = dequeue_signal(ctx->tsk, &ctx->sigmask, &info)) != 0 &&

Grrr, never change the code after you tested it. The above is clearly:

	if ((signo = dequeue_signal(ctx->tsk, &ctx->sigmask, &info)) == 0 &&
		...



- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/