linux-kernel - Re: [PATCH] Fix sparc TIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070310.002944.115909724.davem@davemloft.net>
Date:	Sat, 10 Mar 2007 00:29:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wli@...omorphy.com
Cc:	mathieu.desnoyers@...ymtl.ca, akpm@...ux-foundation.org,
	mbligh@...gle.com, linux-kernel@...r.kernel.org,
	sparclinux@...r.kernel.org
Subject: Re: [PATCH] Fix sparc TIF_USEDFPU flag atomicity

From: William Lee Irwin III <wli@...omorphy.com>
Date: Sat, 10 Mar 2007 00:26:46 -0800

> On Sat, Mar 10, 2007 at 03:17:43AM -0500, Mathieu Desnoyers wrote:
> > @@ -348,7 +348,7 @@ void exit_thread(void)
> >  #ifndef CONFIG_SMP
> >  	if(last_task_used_math == current) {
> >  #else
> > -	if(current_thread_info()->flags & _TIF_USEDFPU) {
> > +	if(test_ti_thread_flag(current_thread_info(), TIF_USEDFPU)) {
> >  #endif
> >  		/* Keep process from leaving FPU in a bogon state. */
> >  		put_psr(get_psr() | PSR_EF);
> 
> Oh dear. Could we bit a bit more idiomatic here? For instance,
> something like:

Ok I pulled the sparc32 patch back out until there is some
consensus here :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/