linux-kernel - Re: [patch] futex: restartable futex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070310090900.GA18250@elte.hu>
Date:	Sat, 10 Mar 2007 10:09:00 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Nick Piggin <npiggin@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ulrich Drepper <drepper@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch] futex: restartable futex_wait


* Nick Piggin <npiggin@...e.de> wrote:

> LTP test sigaction_16_24 fails, because it expects sem_wait to be 
> restarted if SA_RESTART is set. sem_wait is implemented with 
> futex_wait, that currently doesn't support being restarted. Ulrich 
> confirms that the call should be restartable.
> 
> Implement a restart_block method to handle the relative timeout, and 
> allow restarts.
> 
> Signed-off-by: Nick Piggin <npiggin@...e.de>

yeah:

  Acked-by: Ingo Molnar <mingo@...e.hu>

i was totally confused and thought this was the original argument:

> +		restart->arg2 = time;
> +		return -ERESTART_RESTARTBLOCK;

but it's indeed the 'new' relative timeout. (It can still be a tiny bit 
inaccurate because if there are many signals then the signals will delay 
the relative timeout - so absolute timeouts are still better - but your 
fix is correct and needed nevertheless)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/