linux-kernel - Re: and try remove another quirk on this computers Re: [3/6] 2.6.21-rc2: known regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703092134330.10832@woody.linux-foundation.org>
Date:	Fri, 9 Mar 2007 21:41:20 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
cc:	Mathieu Bérard <Mathieu.Berard@...ns.org>,
	Jeff Garzik <jeff@...zik.org>, Adrian Bunk <bunk@...sta.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org,
	Michal Jaegermann <michal@...pspace.math.ualberta.ca>,
	Fabio Comolli <fabio.comolli@...il.com>,
	Tejun Heo <htejun@...il.com>,
	Janosch Machowinski <jmachowinski@....de>,
	Lukas Hejtmanek <xhejtman@...muni.cz>,
	Meelis Roos <mroos@...ux.ee>,
	Olivier Mondoloni <darkcore71@...oo.fr>,
	Thomas Renninger <trenn@...e.de>,
	Robert Moore <robert.moore@...el.com>, lenb@...nel.org,
	linux-acpi@...r.kernel.org
Subject: Re: and try remove another quirk on this computers Re: [3/6]
 2.6.21-rc2: known regressions

On Sat, 10 Mar 2007, Sergio Monteiro Basto wrote:
> 
> With this quirk I got this oops on hibernate (but computer still
> working) 

Well, strictly speaking it's a warning, not an oops per se. 

What happens is that the quirk wants to do an "ioremap_nocache()", which 
allocates memory, and that happens very early during initialization when 
interrupts are disabled.

And you're really not supposed to allocate memory, except using 
GFP_ATOMIC. But we've always been lax about that during early boot, so we 
have stuff that does. And resume ends up doing a lot of the same things 
early boot does, and shows issues like this.

So the quirk is probably still a good idea, and the warning message is 
just that - a very scary warning message, but not an indicator that 
anything is seriously screwed up for you.

(It is an indication of a real bug, though, even though it's harmless in 
practice in this case)

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/