linux-kernel - Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0703120652100.19670@shell2.speakeasy.net>
Date:	Mon, 12 Mar 2007 07:07:39 -0700 (PDT)
From:	Trent Piepho <xyzzy@...akeasy.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	rusty@...tcorp.com.au, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/3] Add ability to keep track of callers of
 symbol_(get|put)

On Sun, 11 Mar 2007, Andrew Morton wrote:
> > On Sat, 10 Mar 2007 02:31:35 -0200 Mauro Carvalho Chehab <mchehab@...radead.org> wrote:
> > From: Trent Piepho <xyzzy@...akeasy.org>
> >
> > When a module uses symbol_get() to increase the ref count of another
> > module, there is no record what module called symbol_get().  A module
> > can
> > show up as having other users, but there is no way to tell who those
> > users are.
> >
> > This adds that ability to symbol_put() and symbol_get().
>
> One day I'll write a script which unwordwraps patches and then you'll all
> need to find new ways of torturing me.
>
> This patch needed rather a lot of help in the coding-style department.
> Hopefully Rusty can comment on the content, because I'm all exhausted from
> cleaning it up.

New version attached.  Coding-style should be fixed, and hopefully this
will not be word-wrapped.

There were some bugs with NULL as the user in symbol_(get|put), that should
be fixed now.

I've added an error message for when a module tries to symbol_put() a
module that it's not using.  This should keep the putted module's ref count
from being set to -1, which is what happens now.  It should also make it a
lot easier to track down where the extra symbol_put()s are comming from.
View attachment "dynamic_dep_kernel.patch" of type "TEXT/PLAIN" (45 bytes)