linux-kernel - Re: [PATCH 1/3] Lumpy Reclaim V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1173724576.11945.100.camel@localhost.localdomain>
Date:	Mon, 12 Mar 2007 11:36:16 -0700
From:	Dave Hansen <hansendc@...ibm.com>
To:	Andy Whitcroft <apw@...dowen.org>
Cc:	Andrew Morton <akpm@...l.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH 1/3] Lumpy Reclaim V4

On Mon, 2007-03-12 at 18:23 +0000, Andy Whitcroft wrote:
> 
> +                       /* The target page is in the block, ignore it. */
> +                       if (unlikely(pfn == page_pfn))
> +                               continue;
> +#ifdef CONFIG_HOLES_IN_ZONE
> +                       /* Avoid holes within the zone. */
> +                       if (unlikely(!pfn_valid(pfn)))
> +                               break;
> +#endif 

Would having something like:

        static inline int pfn_in_zone_hole(unsigned long pfn)
        {
        #ifdef CONFIG_HOLES_IN_ZONE
        	if (unlikely(!pfn_valid(pfn)))
        		return 1;
        #endif 
        	return 0;
        }
        
help us out?  page_is_buddy() and page_is_consistent() appear to do the
exact same thing, with the same #ifdef.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/