linux-kernel - Re: [BUG} usb-serial regression in 2.6.21-rc2-git3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703121948.21453.oneukum@suse.de>
Date:	Mon, 12 Mar 2007 19:48:19 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	Mark Lord <lkml@....ca>
Cc:	Greg KH <greg@...ah.com>, Adrian Bunk <bunk@...sta.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BUG} usb-serial regression in 2.6.21-rc2-git3

Am Montag, 12. März 2007 17:50 schrieb Mark Lord:
> Mark Lord wrote:
> >
> > Okay, from that part (above), the problem is obvious:
> > in that the "MCT U232 converter now disconnected" appears,
> > and then we continue to try and call the driver's method.. Oops!
> > 
> > The hack patch below "fixes" this, but it really just hides whatever
> > the real problem underneath was:

static void destroy_serial(struct kref *kref):

	/* the ports are cleaned up and released in port_release() */
	for (i = 0; i < serial->num_ports; ++i)
		if (serial->port[i]->dev.parent != NULL) {
			device_unregister(&serial->port[i]->dev);
			serial->port[i] = NULL;
		}

	if (serial->type->shutdown)
		serial->type->shutdown(serial);

IMHO shutdown() is using serial->port[] and bombs.
Could you reverse the order here?

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/