linux-kernel - Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070312141126.651cf967.kristen.c.accardi@intel.com>
Date:	Mon, 12 Mar 2007 14:11:26 -0700
From:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Jeff Garzik <jeff@...zik.org>, len.brown@...el.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now

On Mon, 12 Mar 2007 22:00:15 +0000
Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > Meanwhile, to solve the problem for these people, and without introducing
> > a lot of new code at this stage in the release, perhaps you can suggest 
> > a more accurate way to detect PATA vs. SATA so we can fix the bug?  
> 
> I think the problem starts with the question. It supposes the BIOS knows
> the answer to the question in the first place. It also supposes we
> haven't reconfigured the port in some cases I believe.
> 
> My guess is the problem needs approaching from the other end. Ask the
> question "What does the ACPI BIOS expect it to be ?". If I follow the
> spec correctly we can answer that question by asking what methods (_SDD,
> _GTF etc) it provides.
> 
> I don't think anything else is reliable.
> 
> Alan
> 

Ah - ok, so you are saying we could query the device to see if it supports
STM/GTM and then if we were to use the workaround I suggested for this bug
we could just refuse to execute GTF on devices which support STM (since
they may require execution of STM first).  If you guys decide you want 
the workaround rather than just either disable acpi or remove the acpi patch
entirely, let me know and I'd be glad to rework it, otherwise I'm assuming
you have decided to just disable acpi all together.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/