linux-kernel - Re: [RFC/PATCH 00/59] Make common x86 arch area for i386 and x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070313214512.GM10574@sequoia.sous-sol.org>
Date:	Tue, 13 Mar 2007 14:45:12 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Chris Wright <chrisw@...s-sol.org>,
	Rusty Russell <rusty@...tcorp.com.au>, Andi Kleen <ak@....de>,
	Glauber de Oliveira Costa <glommer@...il.com>
Subject: Re: [RFC/PATCH 00/59] Make common x86 arch area for i386 and x86_64

* Steven Rostedt (rostedt@...dmis.org) wrote:
> Recently I've been doing some work that will affect both the i386 and x86_64
> architectures.  So there will be common code for both, as well as code
> that will be unique for the specific arch.  So I was looking into a way
> to do this cleanly, and found that there is no clean way to share code
> between x86_64 and i386.

Thanks for taking this on.  I'm sure Andi has a bunch of ideas on this
topic, but it would be nice to see the consolidation.

> So the move patches are a simple move of one file, with the slight exception 
> of files that hold the speedstep-lib.h file.  This file was moved from the
> arch/i386/kerne/cpu/cpufreq directory and put into the include/asm-i386
> directory.  This was due to the fact that some of the moved files included
> it, and some files that were not moved also included it. Instead of using
> the #include "../../x86/" hack again, I just simply moved it to the global
> i386 include directory.  Only the arch/x86 will use the include/asm-i386

what about asm-x86/ dir?  the asm/ symlink would still point to relevant
arch, but the file there could be simply #include <asm-x86/file.h> ?

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/